Opened 11 years ago

Closed 10 years ago

#5 closed task (fixed)

BearMail::Web::Login error handling

Reported by: Vincent Caron Owned by: zecrazytux
Priority: minor Component: Bearmail
Keywords: Cc:

Description

We need some error and feedback handling in bearmail login: Add some div in source:/bearmail/template/login.html. I'd suggest a <p class="error"> before the submit button, and only present if an error occurs. I'm not fan on errors "on top" which shift the whole form layout down.

And of course add proper logic in source:/bearmail/lib/BearMail/Web/Login.pm - see if CGI::App has some "standard way" to handle error/flash messages.

I'd like meaningful errors (instead of a single message "Login failed"):

  • "Echec: le mot de passe est incorrect, essayez à nouveau."
  • "Echec: cette adresse email est inconnue."

I know it's supposed to be a privacy issue since a brute force attack can guess the list of hosted domains and addresses, but it's also so convenient for end users who must know if they mispelled their address or password in the first place.

(BTW all public strings are French, let's keep it that way until we add i18n)

Change History (1)

comment:1 Changed 10 years ago by zecrazytux

Resolution: fixed
Status: newclosed

Fixed in 432. I didn't hear of any specific way with cgi::application, except its validation module which is a bit... overpowered :)

I used a basic <TMPL_IF tag>

Note: See TracTickets for help on using tickets.